feat(isthmus): add method converting SQL to POJO Plan#473
Merged
vbarua merged 1 commit intosubstrait-io:mainfrom Aug 11, 2025
Merged
feat(isthmus): add method converting SQL to POJO Plan#473vbarua merged 1 commit intosubstrait-io:mainfrom
vbarua merged 1 commit intosubstrait-io:mainfrom
Conversation
nielspardon
force-pushed
the
par-sqltosubstrait
branch
from
5f8b39e to
7f43ea2
Compare
BREAKING CHANGE: deprecates SqlToSubstrait.execute() Signed-off-by: Niels Pardon <par@zurich.ibm.com>
nielspardon
force-pushed
the
par-sqltosubstrait
branch
from
7f43ea2 to
5d9af13
Compare
vbarua
approved these changes
Aug 11, 2025
Member
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
Changes look good to me. This in inpsired me to push through my own changes extending these. I'll open a PR for those shortly.
Also, I don't believe this a breaking change as you've only deprecated the method, not removed it.
Member
|
Taking this even further in #474 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that #432 could benefit from this refactoring.
BREAKING CHANGE: deprecates SqlToSubstrait.execute()
convert()method toSqlToSubstraitwhich converts a SQL statements string to a POJOPlaninstead of a protoPlanexecute()method inSqlToSubstraitwhich converts a SQL statements string to a protoPlanexecute()in the code toconvert()@VisibleForTestingannotation fromSqlToSubstrait.createSqlToRelConverter()andSqlToSubstrait.getBestExpRelRoot()since they are not actually used in testing and makes themprotectedinstead of package private@VisibleForTestingannotation toSqlToSubstrait.sqlToRelNode()which is actually still used in testingTpcdsQueryTestandTpchQueryTestto test POJO to SQL and PROTO to SQL separately since I noticed that TPC-DS query 67 only fails for PROTO to SQL but started working to POJO to SQL